Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in setup task - create_namespace removal #1872

Closed
wants to merge 2 commits into from

Conversation

macaktom
Copy link
Contributor

@macaktom macaktom commented Feb 5, 2024

Description

Removal of create_namespace task as a subtask of setup task.

Issues:

Refs: #1452

How has this been tested:

Tested by running all tests (workload and platform) and all spec tests.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@HashNuke
Copy link
Collaborator

HashNuke commented Feb 5, 2024

@macaktom Thank you for submitting this PR. I'll add some notes to the original ticket that mentions this issue. I think this change requires a discussion.

The changes in this PR in it's current form could will issues since dependencies could be using this namespace.

Example: https://github.com/cnf-testsuite/cluster_tools/blob/main/cluster_tools.cr#L8

Here is some info to help out: I'm using a VS Code workspace with other dependency repos in the workspace. So I did a quick search. I did a quick search for where ClusterTools.install is being used and I see the following results (screenshot attached).

That search results includes the following dependencies:

CleanShot 2024-02-05 at 23 04 16@2x

@HashNuke
Copy link
Collaborator

HashNuke commented Feb 5, 2024

@macaktom My notes on options to move forward are on #1452.

@HashNuke
Copy link
Collaborator

HashNuke commented Feb 6, 2024

Closing this PR as per discussion on #1452.

@HashNuke HashNuke closed this Feb 6, 2024
@macaktom macaktom deleted the setup-cluster-resources branch February 6, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants