Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pod_memory_hog spec test failing in github actions when PR merged to main #1973

Closed
agentpoyo opened this issue Apr 15, 2024 · 4 comments
Assignees
Labels
bug Something isn't working v1.2.0 Issue included in v1.2.0 release

Comments

@agentpoyo
Copy link
Collaborator

Describe the bug
pod_memory_hog continues to fail in github actions:

I, [2024-04-15 16:45:39 +00:00 #10118]  INFO -- cnf-testsuite: upsert_task: task: pod_memory_hog has status: failed and is awarded: 0 points. Runtime: 96 seconds
I, [2024-04-15 16:45:39 +00:00 #10118]  INFO -- cnf-testsuite: results yaml: {"name" => "cnf testsuite", "testsuite_version" => "main-2024-04-15-164445-5a8da5dc", "status" => nil, "command" => "/home/runner/work/testsuite/testsuite/cnf-testsuite pod_memory_hog verbose", "points" => nil, "exit_code" => 0, "items" => [{"name" => "pod_memory_hog", "status" => "failed", "type" => "normal", "points" => 0}]}


  'pod_memory_hog' A 'Good' CNF should not crash when pod memory hog occurs

Failures:

  1) Resilience pod memory hog Chaos 'pod_memory_hog' A 'Good' CNF should not crash when pod memory hog occurs
     Failure/Error: (/PASSED: pod_memory_hog chaos test passed/ =~ response_s).should_not be_nil

       Expected: nil not to be nil

Error:      # spec/workload/resilience/pod_memory_hog_spec.cr:22

Finished in 2:21 minutes
1 examples, 1 failures, 0 errors, 0 pending

Failed examples:

crystal spec spec/workload/resilience/pod_memory_hog_spec.cr:15 # Resilience pod memory hog Chaos 'pod_memory_hog' A 'Good' CNF should not crash when pod memory hog occurs
Error: Process completed with exit code 1.

To Reproduce
Merges to main reproduce the errors.

Expected behavior
Should pass and not fail.

@agentpoyo agentpoyo added the bug Something isn't working label Apr 15, 2024
@lixuna lixuna moved this to In Progress in CNTI Test Catalog Apr 17, 2024
@taylor
Copy link
Member

taylor commented Apr 18, 2024

There is a Litmus Chaos error happening. Before trying to debug we are upgrading Litmus which requires some updates in code integration to the tools and litmus test cases.

This issue is blocking #1949

@taylor
Copy link
Member

taylor commented Apr 18, 2024

Need a new issue to handle constraints in pods, dynamically reading the constraint and telling Litmus to not use more than about 95% of the constraint.

If it uses 100% it will cause kubernetes to kill the pod which causes a failure. That is a different type of test.

@taylor
Copy link
Member

taylor commented Apr 18, 2024

Spec bug can be fixed with hardcoding to lower than 80% of coredns. This is not ideal though

taylor pushed a commit that referenced this issue Apr 18, 2024
taylor pushed a commit that referenced this issue Apr 18, 2024
wvwatson pushed a commit that referenced this issue Apr 19, 2024
wvwatson pushed a commit that referenced this issue Apr 19, 2024
haskojur pushed a commit to haskojur/testsuite that referenced this issue Apr 24, 2024
haskojur pushed a commit to haskojur/testsuite that referenced this issue Apr 24, 2024
haskojur pushed a commit to haskojur/testsuite that referenced this issue Apr 24, 2024
haskojur pushed a commit to haskojur/testsuite that referenced this issue Apr 24, 2024
haskojur pushed a commit to haskojur/testsuite that referenced this issue Apr 24, 2024
haskojur pushed a commit to haskojur/testsuite that referenced this issue Apr 24, 2024
haskojur pushed a commit to haskojur/testsuite that referenced this issue Apr 24, 2024
@lixuna lixuna moved this from In Progress to Peer Review in CNTI Test Catalog May 8, 2024
@lixuna lixuna added the v1.2.0 Issue included in v1.2.0 release label May 8, 2024
@kosstennbl
Copy link
Collaborator

Issue seems to be fixed with #1987.
image
Continuation and further improvement of "pod_memory_hog" test is described in #1989

@github-project-automation github-project-automation bot moved this from Peer Review to Done in CNTI Test Catalog Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.2.0 Issue included in v1.2.0 release
Projects
None yet
Development

No branches or pull requests

6 participants