Feat: Design Issues #968

BrunoAmbricca · 2024-12-01T14:49:58Z

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

Bugfix

Resolves: #946

Summary by CodeRabbit

New Features
- Enhanced visual layout for quest categories on small screens.
- Improved user interface clarity with a new message indicating completion status of quests.
Bug Fixes
- Refined logic for displaying completed boosts to accurately reflect quest completion status.

vercel · 2024-12-01T14:50:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sepolia-starknet-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 2, 2024 5:25pm
starknet-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 2, 2024 5:25pm

vercel · 2024-12-01T14:50:04Z

@BrunoAmbricca is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2024-12-01T14:50:05Z

Walkthrough

The changes in questAndCollectionTabs.tsx focus on enhancing the component's rendering logic and layout. Key modifications include the addition of a bottom padding class for small screens and refined conditional rendering for completed quests. The overall structure, state management, and error handling remain unchanged, ensuring consistent functionality while improving visual spacing and user interface clarity.

Changes

File	Change Summary
components/pages/home/questAndCollectionTabs.tsx	Added `pb-5` class for bottom padding on small screens; refined logic for displaying completed quests.

Assessment against linked issues

Objective	Addressed	Explanation
Bottom Padding	✅

Possibly related PRs

feat: karnot quest visuals #965: The changes in questAndCollectionTabs.tsx involve layout adjustments and rendering logic for quest displays, which are related to the new QuestBanner component introduced in questBanner.tsx and its integration into the QuestDetails component, enhancing the overall quest visuals and user experience.

Suggested labels

🔥 Ready for review

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @typescript-eslint/eslint-plugin@5.62.0
npm error Found: eslint@9.14.0
npm error node_modules/eslint
npm error dev eslint@"^9.11.1" from the root project
npm error peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.4.1
npm error node_modules/@eslint-community/eslint-utils
npm error @eslint-community/eslint-utils@"^4.2.0" from @typescript-eslint/utils@5.62.0
npm error node_modules/@typescript-eslint/utils
npm error @typescript-eslint/utils@"5.62.0" from @typescript-eslint/eslint-plugin@5.62.0
npm error node_modules/@typescript-eslint/eslint-plugin
npm error dev @typescript-eslint/eslint-plugin@"^5.47.0" from the root project
npm error 1 more (eslint-config-next)
npm error 1 more (@typescript-eslint/type-utils)
npm error @eslint-community/eslint-utils@"^4.2.0" from eslint@9.14.0
npm error 5 more (@typescript-eslint/type-utils, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0" from @typescript-eslint/eslint-plugin@5.62.0
npm error node_modules/@typescript-eslint/eslint-plugin
npm error dev @typescript-eslint/eslint-plugin@"^5.47.0" from the root project
npm error @typescript-eslint/eslint-plugin@"^5.4.2 || ^6.0.0 || ^7.0.0 || ^8.0.0" from eslint-config-next@14.2.17
npm error node_modules/eslint-config-next
npm error dev eslint-config-next@"^14.0.1" from the root project
npm error
npm error Conflicting peer dependency: eslint@8.57.1
npm error node_modules/eslint
npm error peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0" from @typescript-eslint/eslint-plugin@5.62.0
npm error node_modules/@typescript-eslint/eslint-plugin
npm error dev @typescript-eslint/eslint-plugin@"^5.47.0" from the root project
npm error @typescript-eslint/eslint-plugin@"^5.4.2 || ^6.0.0 || ^7.0.0 || ^8.0.0" from eslint-config-next@14.2.17
npm error node_modules/eslint-config-next
npm error dev eslint-config-next@"^14.0.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /root/.npm/_logs/2024-12-02T17_25_02_200Z-eresolve-report.txt
npm error A complete log of this run can be found in: /root/.npm/_logs/2024-12-02T17_25_02_200Z-debug-0.log

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 527b799 and 190c1e3.

📒 Files selected for processing (1)

components/pages/home/questAndCollectionTabs.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

components/pages/home/questAndCollectionTabs.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

fricoben

Nothing changed we still have the problem here

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

components/pages/home/questAndCollectionTabs.tsx (1)
234-234: Consider a more consistent spacing approach.

While the bottom padding addresses the immediate issue, consider these improvements for better maintainability:

Use consistent spacing methods (either all margins or all padding)

Make all spacing responsive using Tailwind's breakpoint prefixes

Example refactor:
-<div className="flex flex-col items-center space-y-6 sm:pb-5">
+<div className="flex flex-col items-center space-y-4 sm:space-y-6 py-4 sm:py-5">

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a534dea and adc994f.

📒 Files selected for processing (1)

components/pages/home/questAndCollectionTabs.tsx (1 hunks)

🔇 Additional comments (1)

components/pages/home/questAndCollectionTabs.tsx (1)

234-234: LGTM! The padding change addresses the mobile view spacing issue.

The addition of sm:pb-5 class provides appropriate bottom padding for the cards section on small screens, directly resolving the design issue mentioned in #946.

fricoben

Well it still doesn't work please test stuff before sending

Marchand-Nicolas · 2024-12-02T16:02:59Z

components/pages/home/questAndCollectionTabs.tsx

@@ -231,7 +231,7 @@ const QuestAndCollectionTabs: FunctionComponent<
            )}
          </CustomTabPanel>
          <CustomTabPanel value={tabIndex} index={1}>
-            <div className="flex flex-col items-center space-y-6">
+            <div className="flex flex-col items-center space-y-6 pb-5 lg:pb-0">


This should not be added there, but on line 214 (the quest list)

I moved the code to the line you said but it didnt aplly the padding. Please check if it works for you

Marchand-Nicolas

Lgtm

add padding

2cb792c

mobile

adc994f

vercel bot deployed to Preview – starknet-quest December 1, 2024 14:53 View deployment

fricoben requested changes Dec 1, 2024

View reviewed changes

coderabbitai bot reviewed Dec 1, 2024

View reviewed changes

fix

d910c79

vercel bot deployed to Preview – starknet-quest December 1, 2024 15:34 View deployment

BrunoAmbricca requested a review from fricoben December 1, 2024 17:12

fricoben requested changes Dec 2, 2024

View reviewed changes

resolution fix

527b799

vercel bot deployed to Preview – starknet-quest December 2, 2024 13:39 View deployment

Marchand-Nicolas requested changes Dec 2, 2024

View reviewed changes

Marchand-Nicolas added the ❌ Change request Change requested from reviewer label Dec 2, 2024

fix

190c1e3

vercel bot deployed to Preview – starknet-quest December 2, 2024 17:25 View deployment

BrunoAmbricca requested a review from Marchand-Nicolas December 2, 2024 17:26

Marchand-Nicolas approved these changes Dec 2, 2024

View reviewed changes

fricoben merged commit c4bb9e0 into lfglabs-dev:testnet Dec 3, 2024
2 of 3 checks passed

BrunoAmbricca deleted the fix-card-padding branch December 3, 2024 02:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Design Issues #968

Feat: Design Issues #968

BrunoAmbricca commented Dec 1, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Dec 1, 2024 •

edited

Loading

vercel bot commented Dec 1, 2024

coderabbitai bot commented Dec 1, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

fricoben left a comment

coderabbitai bot left a comment

fricoben left a comment

Marchand-Nicolas Dec 2, 2024

BrunoAmbricca Dec 2, 2024 •

edited

Loading

Marchand-Nicolas left a comment

Feat: Design Issues #968

Feat: Design Issues #968

Conversation

BrunoAmbricca commented Dec 1, 2024 • edited by coderabbitai bot Loading

Pull Request type

Summary by CodeRabbit

vercel bot commented Dec 1, 2024 • edited Loading

vercel bot commented Dec 1, 2024

coderabbitai bot commented Dec 1, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

fricoben left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

fricoben left a comment

Choose a reason for hiding this comment

Marchand-Nicolas Dec 2, 2024

Choose a reason for hiding this comment

BrunoAmbricca Dec 2, 2024 • edited Loading

Choose a reason for hiding this comment

Marchand-Nicolas left a comment

Choose a reason for hiding this comment

BrunoAmbricca commented Dec 1, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Dec 1, 2024 •

edited

Loading

coderabbitai bot commented Dec 1, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

BrunoAmbricca Dec 2, 2024 •

edited

Loading