Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint and prettier job to CI and add caching #163

Merged
merged 19 commits into from
Jun 30, 2023
Merged

Add eslint and prettier job to CI and add caching #163

merged 19 commits into from
Jun 30, 2023

Conversation

axmmisaka
Copy link
Collaborator

No description provided.

@axmmisaka
Copy link
Collaborator Author

Sorry, just discovered I kinda screwed up in #160......

lhstrh
lhstrh reviewed Jun 10, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Should we fix the any warnings before merging this?

.eslintrc.js Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@lhstrh
Copy link
Member

lhstrh commented Jun 10, 2023 •
edited
Loading

Sorry, just discovered I kinda screwed up in #160......

❓

@axmmisaka
Copy link
Collaborator Author

Sorry, just discovered I kinda screwed up in #160......

❓

a614262
I didn't fix all eslint issues nor did I run prettier after the last commit in #160......

@axmmisaka axmmisaka mentioned this pull request Jun 29, 2023
Merged
@axmmisaka
Copy link
Collaborator Author

Since we want to assume #157 will be merged and considering the fact that #170 is merged and this PR should be based off of that branch, a reset will be performed.

lhstrh
lhstrh approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@axmmisaka axmmisaka merged commit 9c7ff65 into lf-lang:master Jun 30, 2023
@axmmisaka axmmisaka deleted the axmmisaka/additional-ci-tasks branch June 30, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axmmisaka @lhstrh