Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutation connect test #107

Merged
merged 7 commits into from
Jul 23, 2022
Merged

Mutation connect test #107

merged 7 commits into from
Jul 23, 2022

Conversation

Wonseo-C
Copy link
Collaborator

@Wonseo-C Wonseo-C commented Jul 8, 2022

  1. Modifying mutation test case file: Adding test case in one test function. ( There is some error when other test cases affect their test case. So we check if there are some dependencies.)
  2. Modifying reachableOrigins function: changing the DFS logic clearly
  3. Modifying _findOwnOutputs (Inport -> Outport: copy-paste error)
  4. The discussion: We must fix the mutation's connect function. (The sequence test case has a dependency. It is not our intention)
    • Distinguish from dependency graph between mutation and reactor
    • Make sure that the dependency graph is added when the mutation is declared

Debugging with @lhstrh @CloverCho

@Wonseo-C Wonseo-C marked this pull request as draft July 13, 2022 02:17
@lhstrh lhstrh merged commit 785550d into lf-lang:test-coverage Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants