Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API Platform integration #1119

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Fix API Platform integration #1119

merged 1 commit into from
Apr 11, 2023

Conversation

maxhelias
Copy link
Contributor

Fix #1118

@alanpoulain
Copy link
Contributor

alanpoulain commented Feb 21, 2023

Couldn't we add an enabled parameter (false by default, but true in the recipe)? It's too bad to give up this behavior.

@maxhelias
Copy link
Contributor Author

@alanpoulain I can modify to add canEnabled() in the configuration but having it true in the recipe without APIP installed may break the bundle out of the box

@maxhelias
Copy link
Contributor Author

But it could be set to true with a prepend in the APIP extension, no ?

@alanpoulain
Copy link
Contributor

alanpoulain commented Feb 21, 2023

Having it to true should not prevent the detection of API Platform. This parameter is only to disable the integration if needed and prevent the BC break.
Doing it with a prepend in API Platform would be a BC break too.

@maxhelias
Copy link
Contributor Author

@alanpoulain should be good now
@chalasr the CI "Tests / PHP 8.2 - Sf 6.3" should be fix in #1120

@jonag
Copy link

jonag commented Feb 27, 2023

Thank you for your PR, it should fix the issue described in #1118. Personally I'm fine with both options (enabled ou disabled by default) since (in my case at least) it doesn't "break" my application but just add a new (non-working and wrongly documented) operation. I don't mind having to disable it manually.

@chalasr
Copy link
Collaborator

chalasr commented Apr 11, 2023

Thank you @maxhelias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deactivate API Platform automatic integration
4 participants