-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix API Platform integration #1119
Conversation
Couldn't we add an enabled parameter (false by default, but true in the recipe)? It's too bad to give up this behavior. |
@alanpoulain I can modify to add |
But it could be set to true with a prepend in the APIP extension, no ? |
Having it to true should not prevent the detection of API Platform. This parameter is only to disable the integration if needed and prevent the BC break. |
@alanpoulain should be good now |
Thank you for your PR, it should fix the issue described in #1118. Personally I'm fine with both options (enabled ou disabled by default) since (in my case at least) it doesn't "break" my application but just add a new (non-working and wrongly documented) operation. I don't mind having to disable it manually. |
Thank you @maxhelias. |
Fix #1118