Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean 3.x #1108

Merged
merged 6 commits into from
May 6, 2023
Merged

Clean 3.x #1108

merged 6 commits into from
May 6, 2023

Conversation

maxhelias
Copy link
Contributor

@maxhelias maxhelias commented Jan 27, 2023 •
edited
Loading

  • Remove namshi/jose
  • Remove support < PHP8.1 & < Symfony 5.4
  • Support of PHPUnit 9.5
  • Update documentation
  • Create an upgrade file

@chalasr
Copy link
Collaborator

chalasr commented Jan 28, 2023

Great, thanks. Don't hesitate to tell me if you want some help regarding the test setup or anything, happy to do so.

@maxhelias
Copy link
Contributor Author

maxhelias commented Jan 29, 2023 •
edited
Loading

@chalasr A merge of the 2.x into the 3.x would be nice to start. I'll let you know afterwards

@chalasr
Copy link
Collaborator

chalasr commented Jan 30, 2023

@maxhelias done in 3711d6f

@maxhelias maxhelias force-pushed the remove-namshi-jose branch 2 times, most recently from efa6983 to b73e6dc Compare January 30, 2023 11:08
@maxhelias
Copy link
Contributor Author

Thanks @chalasr !

It's difficult to fix the CI without cleaning the code base for symfony > 5.4. I can do it here and I can increase the compatibility with php too. Like > 8.1 ? WDYT ?

@chalasr
Copy link
Collaborator

chalasr commented Feb 3, 2023

Yes, please go ahead :) Requiring PHP 8.1+ and Symfony 6.2+ is fine to me

@maxhelias maxhelias changed the title Remove namshi/jose on 3.x Clean 3.x Feb 8, 2023
@maxhelias maxhelias marked this pull request as ready for review February 8, 2023 11:43
@maxhelias
Copy link
Contributor Author

@chalasr it's ready for a review 😄

@maxhelias maxhelias mentioned this pull request Feb 10, 2023
Merged
chalasr added a commit that referenced this pull request Feb 12, 2023
@chalasr
bug #1115 Fix ci 2.x (maxhelias)
c7d2d70 
This PR was squashed before being merged into the 2.x branch.

Discussion
----------

Fix ci 2.x

Fix #1114 and all CI.

PHP 7.1 and symfony 4.4 cannot be tested in the CI but are still supported. Mainly because of the tests that need the browser-kit 5.4 at least and interface compatibility (without/with typing)

`@chalasr` after merge this, I would like a rebase on 3.x so that I can rework my other PR : #1108

Commits
-------

be8ed34 Fix ci 2.x
@maxhelias
Copy link
Contributor Author

@chalasr can you merge 2.x into 3.x that i rework this PR. Thanks

@chalasr
Copy link
Collaborator

chalasr commented Mar 1, 2023

@maxhelias done, rebase unlocked!

@maxhelias maxhelias force-pushed the remove-namshi-jose branch 3 times, most recently from 78f0b7b to f385056 Compare March 1, 2023 19:14
@maxhelias maxhelias force-pushed the remove-namshi-jose branch from f385056 to 4505629 Compare March 1, 2023 19:17
@maxhelias
Copy link
Contributor Author

Thanks @chalasr ! Everything is good, I would like to have a first review. All that's left is to make the file UPGRADE-3.x.md

@chalasr chalasr self-requested a review April 11, 2023 12:22
@chalasr
Copy link
Collaborator

chalasr commented May 6, 2023

Thanks a ton Max! You rock.

@chalasr chalasr merged commit 4eb6bcd into lexik:3.x May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxhelias @chalasr