Update Hyprland URL to new format #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tyvm! Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hyprwm/Hyprland#5667 was merged into Hyprland meaning the flake URL was changed from something like:
inputs.hyprland.url = "github:hyprwm/Hyprland";to:
inputs.hyprland.url = "git+https://github.com/hyprwm/Hyprland?submodules=1";in our case that's from something like
"github:hyprwm/Hyprland/v0.40.0"->"git+https://github.com/hyprwm/Hyprland?submodules=1&ref=refs/tags/v0.40.0".While the commits 5677 introduced don't apply to v0.40.0, it still builds with this URL, so i thought it would be better to preemptively update it and not get a surprise breakage later.
I also updated the README to reflect this change.
Haven't tested, but built and the $out path is different, but binary files are exactly the same, so shouldn't need testing, but it would be helpful since im not 100% sure about the inputs.hyprland.follows behavior, but it should be the same.
I also checked the flake.lock and the changes it made seem correct.