fixing dry-run on ci

levibostian · Nov 21, 2023 · 5c4654c · 5c4654c
1 parent 5edfcd5
commit 5c4654c
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -1,9 +1,9 @@
 name: Run tests 
 
-on: [pull_request]
+on: [pull_request, push]
 
 jobs:
-  run-tests: 
+  run-tests:   
     runs-on: ubuntu-latest
     steps: 
     - uses: actions/checkout@v3
@@ -14,6 +14,7 @@ jobs:
     - run: npm run test
 
   run-plugin-in-semantic-release:
+    if: github.event_name == 'push' # semantic-release only seems to work when running on push, not on pull_request because of temp branch made during PRs. 
     runs-on: ubuntu-latest
     permissions:
       contents: write # to set permissions for semantic-release dry-run to pass 
@@ -35,7 +36,6 @@ jobs:
         git config --global user.name "Example User"
 
     - name: Run semantic-release in dry run
-      run: unset GITHUB_ACTIONS && npx semantic-release --dry-run --no-ci --branches "${REF_NAME},main" --plugins "semantic-release-cocoapods"
+      run: unset GITHUB_ACTIONS && npx semantic-release --dry-run --no-ci --branches "${{ github.ref_name }},main" --plugins "semantic-release-cocoapods"
       env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        REF_NAME: ${{ github.ref_name }}
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}