Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

fix(ts): update ts module & moduleResolution #319

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

joeldavidw
Copy link
Contributor

What this PR does / why we need it:

In ts 5.2 onwards module and moduleResolution has to be set to node16 or nodenext

https://devblogs.microsoft.com/typescript/announcing-typescript-5-2/

Which issue(s) will this PR fix?:

Fixes #

Additional comments?:

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for stickyjs ready!

Name Link
🔨 Latest commit b979b26
🔍 Latest deploy log https://app.netlify.com/sites/stickyjs/deploys/6595017f1f894c0008fdc292
😎 Deploy Preview https://deploy-preview-319--stickyjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f328cb) 73.83% compared to head (b979b26) 73.83%.
Report is 64 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files           7        7           
  Lines         172      172           
  Branches       19       19           
=======================================
  Hits          127      127           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeldavidw joeldavidw merged commit b9d18a2 into main Jan 3, 2024
17 checks passed
@joeldavidw joeldavidw deleted the joeldavidw/update-ts-module branch January 3, 2024 06:44
joeldavidw added a commit that referenced this pull request Jan 3, 2024
joeldavidw added a commit that referenced this pull request Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant