fix: remove the missing arg name from create_tool in client.py
#2428
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
his commit modifies the create_tool method to automatically derive the name of the tool from the function's __name__ attribute instead of requiring it as a parameter.
azinasg
changed the title
name from create_tool() in client.pyname from create_tool in client.py
|
@azinasg could you please use the official Python SDK instead? We are going to deprecate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
his commit modifies the create_tool method to automatically derive the name of the tool from the function's name attribute instead of requiring it as a parameter.
Please describe the purpose of this pull request.
The purpose of this pull request is to fix a bug. The bug occurred because the name variable was missing in the function signature of the create_tool method. The fix automatically derives the tool's name from the function's name attribute, removing the need for it as a separate parameter.
How to test
Yes, this fix has been tested locally with a few functions and the tool names are set correctly. However, the testing wasn’t extensive. Please check the solution and let me know if the function still needs the
nameparameter or if this fix works.Have you tested this PR?
N/A
Related issues or PRs
N/A
Is your PR over 500 lines of code?
No, this PR changes 2 lines of code.
Additional context
N/A