Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup catching non-existent return value (#2202) #2380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kk-src
Copy link
Contributor

@kk-src kk-src commented Jan 23, 2025

Please describe the purpose of this pull request.

Fixes issue #2202. The user_manager.list_users returns the combined user list, without next cursor. This patch cleans up the code to not capture non-existent return value and thus fixes the listing of users.

How to test

Listing users will succeed.

Have you tested this PR?

Tested by running the server locally and using curl to get the users. Here is the relevant snippet:

curl -X GET -L "http://127.0.0.1:8283/v1/admin/users"
[{"id":"user-00000000-0000-4000-8000-000000000000","organization_id":"org-00000000-0000-4000-8000-000000000000","name":"default_user",......

Related issues or PRs

#2202

Is your PR over 500 lines of code?
N/A

Additional context
A future TODO (if needed) is to add tests for list users. At the moment due to 7ad5f01 the test are broken (gives ModuleNotFoundError: No module named 'openai').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant