fix: remove incremental done steps #2283

carenthomas · 2024-12-19T01:53:09Z

Please describe the purpose of this pull request.
don't stream done tokens in between multi step requests, only support the final done token

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?
poetry run pytest -s -vv tests/test_client_legacy.py::test_streaming_send_message

Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.

Related issues or PRs
Please link any related GitHub issues or PRs.

Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.

Additional context
Add any other context or screenshots about the PR here.

carenthomas

a little complicated because this value is used in the LettaStreamingResponse return value which is a union of different types, so wasn't able to just directly use the constant everywhere. this has the implication that LettaStreamingResponse can no longer be used in isinstance checks since StreamDoneStatus is not a class

letta/server/rest_api/routers/v1/agents.py

tests/test_client_legacy.py

letta/client/streaming.py

letta/server/rest_api/interface.py

cpacker · 2024-12-21T00:48:30Z

Example main:

curl -X POST \
    -H 'Content-Type: application/json' \
    -H 'Accept: text/event-stream' \
    -d '{
  "messages": [
    {
      "role": "user",
      "text": "hello there!"
    }
  ],
  "stream_steps": true,
  "stream_tokens": true
}' \
    http://localhost:8283/v1/agents/agent-6272c3d2-c33b-4ead-8cc7-372df841ea09/messages/stream

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":"User"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" has"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" just"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" logged"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" in"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" and"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" greeted"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" me"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":"."}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" Let's"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" keep"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" this"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" friendly"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" and"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":" engaging"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"reasoning_message","reasoning":"!"}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"name":"send_message","tool_call_id":"2ea15c97-2824-46a2-9c91-eae62"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":"{\"message\":\""}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":"Hey"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" there"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":"!"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" It's"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" great"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" to"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" have"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" you"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" here"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":"."}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" How"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" can"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" I"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" help"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" you"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":" today"}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":"?\""}}

data: {"id":"message-9c703ecd-6ca9-4069-a3fe-690a38f9ec5e","date":"2024-12-21T00:47:23+00:00","message_type":"tool_call_message","tool_call":{"arguments":"}"}}

data: [DONE_GEN]

data: {"id":"message-0213b36e-5b1c-4f8c-be60-77cff90a2ebb","date":"2024-12-21T00:47:25+00:00","message_type":"tool_return_message","tool_return":"None","status":"success","tool_call_id":"2ea15c97-2824-46a2-9c91-eae62","stdout":null,"stderr":null}

data: [DONE_STEP]

data: {"usage":{"completion_tokens":45,"prompt_tokens":2620,"total_tokens":2665,"step_count":1}}

data: [DONE]

cpacker · 2024-12-21T00:49:09Z

Example caren/let-591-move-to-using-only-done-for-the-streaming-api

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":"User"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":" repeated"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":" their"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":" greeting"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":"."}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":" I"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":" should"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":" acknowledge"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":" it"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":" and"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":" encourage"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":" a"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":" conversation"}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"reasoning_message","reasoning":"."}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"name":"send_message","tool_call_id":"14b6e622-a80d-4dc7-a8f6-c282d"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":"{\"message\":\"Hello"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" again"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":"!"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" What's"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" on"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" your"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" mind"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":"?"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" I'm"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" here"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" to"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" help"}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":".\""}}

data: {"id":"message-dbdeac83-808a-4bb0-bb9b-0cbb70c11ec2","date":"2024-12-21T00:48:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":"}"}}

data: {"id":"message-fb544286-9cee-47a1-b7d7-702400be487a","date":"2024-12-21T00:48:58+00:00","message_type":"tool_return_message","tool_return":"None","status":"success","tool_call_id":"14b6e622-a80d-4dc7-a8f6-c282d","stdout":null,"stderr":null}

data: {"id":"null","date":"2024-12-21T00:48:58+00:00","message_type":"usage_message","usage":{"completion_tokens":38,"prompt_tokens":2821,"total_tokens":2859,"step_count":1}}

data: [DONE]

cpacker · 2024-12-21T00:54:47Z

data: {"id":"message-fb544286-9cee-47a1-b7d7-702400be487a","date":"2024-12-21T00:48:58+00:00","message_type":"tool_return_message","tool_return":"None","status":"success","tool_call_id":"14b6e622-a80d-4dc7-a8f6-c282d","stdout":null,"stderr":null}

data: {"id":"null","date":"2024-12-21T00:48:58+00:00","message_type":"usage_message","usage":{"completion_tokens":38,"prompt_tokens":2821,"total_tokens":2859,"step_count":1}}

data: [DONE]

Only comment: both id and date should be nullable, and we should omit nulls on the SSE emit.

…n sse stream

cpacker · 2024-12-21T01:00:14Z

Patched:

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":"User"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" keeps"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" greeting"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" me"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":"."}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" They"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" might"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" be"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" testing"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" responses"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" or"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" looking"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" for"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":" engagement"}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"reasoning_message","reasoning":"."}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"name":"send_message","tool_call_id":"bd1d6c9d-e10e-4dc0-bac9-3a2cf"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":"{\"message\":\"Hey"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" there"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" again"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":"!"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" I'm"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" really"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" glad"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" to"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" see"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" you"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":"!"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" How"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" can"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" I"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" assist"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" you"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":" today"}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":"?\""}}

data: {"id":"message-adace973-b750-421c-8bff-b43eff19d27b","date":"2024-12-21T00:58:57+00:00","message_type":"tool_call_message","tool_call":{"arguments":"}"}}

data: {"id":"message-4e700b4a-d3a6-42ff-b10e-6bd95d8898a0","date":"2024-12-21T00:58:58+00:00","message_type":"tool_return_message","tool_return":"None","status":"success","tool_call_id":"bd1d6c9d-e10e-4dc0-bac9-3a2cf","stdout":null,"stderr":null}

data: {"message_type":"usage_message","usage":{"completion_tokens":44,"prompt_tokens":3016,"total_tokens":3060,"step_count":1}}

data: [DONE]

tests/test_client_legacy.py

…e-streaming-api

cpacker · 2024-12-21T01:12:29Z

Deprecated in favor of #2297

carenthomas · 2025-01-02T22:01:32Z

Re-implemented here: https://github.com/letta-ai/letta-cloud/pull/504

carenthomas temporarily deployed to Deployment December 19, 2024 01:53 — with GitHub Actions Inactive

carenthomas commented Dec 19, 2024

View reviewed changes

letta/server/rest_api/routers/v1/agents.py Show resolved Hide resolved

tests/test_client_legacy.py Outdated Show resolved Hide resolved

letta/client/streaming.py Show resolved Hide resolved

letta/server/rest_api/interface.py Show resolved Hide resolved

sarahwooders requested a review from cpacker December 19, 2024 02:10

Caren Thomas added 2 commits December 20, 2024 09:27

remove incremental done steps

b326ed1

comment out steps instead of deleting

c1309cf

carenthomas force-pushed the caren/let-591-move-to-using-only-done-for-the-streaming-api branch from eb117a9 to c1309cf Compare December 20, 2024 18:19

carenthomas temporarily deployed to Deployment December 20, 2024 18:19 — with GitHub Actions Inactive

carenthomas requested a review from sarahwooders December 20, 2024 21:58

add wrapper class for just streaming case

e721e33

carenthomas temporarily deployed to Deployment December 20, 2024 22:49 — with GitHub Actions Inactive

fix: made base fields nullable, added exclude none on emit of usage i…

907811d

…n sse stream

cpacker reviewed Dec 21, 2024

View reviewed changes

tests/test_client_legacy.py Show resolved Hide resolved

Merge branch 'main' into caren/let-591-move-to-using-only-done-for-th…

ed887cb

…e-streaming-api

cpacker had a problem deploying to Deployment December 21, 2024 01:04 — with GitHub Actions Failure

fix: patch test

c681f66

cpacker had a problem deploying to Deployment December 21, 2024 01:05 — with GitHub Actions Failure

cpacker closed this Dec 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove incremental done steps #2283

fix: remove incremental done steps #2283

carenthomas commented Dec 19, 2024

carenthomas left a comment

cpacker commented Dec 21, 2024

cpacker commented Dec 21, 2024

cpacker commented Dec 21, 2024

cpacker commented Dec 21, 2024

cpacker commented Dec 21, 2024

carenthomas commented Jan 2, 2025

fix: remove incremental done steps #2283

fix: remove incremental done steps #2283

Conversation

carenthomas commented Dec 19, 2024

carenthomas left a comment

Choose a reason for hiding this comment

cpacker commented Dec 21, 2024

cpacker commented Dec 21, 2024

cpacker commented Dec 21, 2024

cpacker commented Dec 21, 2024

cpacker commented Dec 21, 2024

carenthomas commented Jan 2, 2025