Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P093 Mitsubishi HeatPump #4813

Merged
merged 10 commits into from
Oct 22, 2023
Merged

P093 Mitsubishi HeatPump #4813

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
98af072
P093 Mitsubishi HeatPump
jfmennedy Sep 21, 2023
cc14a49
Modify Changelog Order
jfmennedy Sep 21, 2023
ed4a0c2
Help needed here
jfmennedy Sep 22, 2023
0f042b6
- Fix float initialisaton,
jfmennedy Sep 23, 2023
d61506d
-Fix static const uint8_t RemoteTemperature
jfmennedy Sep 23, 2023
242051e
- Implement remarks from review
jfmennedy Sep 23, 2023
bb11167
Documentation
jfmennedy Sep 25, 2023
516fd1a
Documentation Review
jfmennedy Sep 25, 2023
92d33d0
Merge branch 'mega' into dev
TD-er Sep 26, 2023
06a2009
Merge branch 'mega' into dev
jfmennedy Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/source/Plugin/P093.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ See: :ref:`SerialHelper_page`

Once we hit submit, the plugin will start sending messages through controller, i.e. MQTT with payload:

``{"roomTemperature":25.5,"wideVane":"|","power":"OFF","mode":"COOL","fan":"AUTO","vane":"AUTO","iSee":true,"operating":true,"compressorFrequency":5,"temperature":24.0}``
``{"roomTemperature":19.5,"wideVane":"|","power":"OFF","mode":"HEAT","fan":"AUTO","vane":"AUTO","iSee":false,"operating":false,"compressorFrequency":2,"temperature":22.0,"remoteTemperature":19.5}``

Message is send every time a change is detected (i.e. one changes settings using IR remote control) and every X seconds, as set in the settings (60 seconds in above screenshot).

Expand Down Expand Up @@ -127,6 +127,12 @@ Special thanks
Change log
----------

.. versionchanged:: 2023/09/25
...

|added|
Set Remote Temperature (greater than 0.0 external Temperature Sensor is used. equal 0.0 internal Temperature Sensor is used.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to read this multiple times before it hit me what you tried to tell here.
Maybe the column width in this Git diff view isn't helping...

Anyway, maybe this is easier to grasp:

Set Remote Temperature. (value > 0: Use external temperature sensor, value = 0: Use internal temperature sensor)


.. versionchanged:: 2021/08/03
...

Expand Down
5 changes: 5 additions & 0 deletions docs/source/Plugin/P093_commands.repl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,8 @@
","
Value = ``<<``, ``<``, ``|``, ``>``, ``>>``, ``<>`` or ``SWING``
"
"
``MitsubishiHP,remotetemperature,<value>``
","
Value equal ``0.0`` uses internal Temperature Sensor and greater than ``0.0`` external Temperature Sensor .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use same wording here? (I like the use of backticks for the numbers by the way)

"
6 changes: 6 additions & 0 deletions docs/source/Plugin/P093_config_values.repl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
| ``[<taskname>#roomTemperature]``
","
| Value as received from the connected device, includes 1 decimal.
| When Remote Temperature is used, received value is rounded by 0.5.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Rounded to the nearest 0.5 C"

"
"
| ``[<taskname>#wideVane]``
Expand Down Expand Up @@ -52,3 +53,8 @@
","
| Value as received from the connected device, when ``Include AC status`` is enabled.
"
"
| ``[<taskname>#remoteTemperature]``
","
| Value as received from the connected device, includes 1 decimal.
"