Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P013] Add setting for trigger-width and Combined mode #4442

Merged
merged 20 commits into from
Mar 29, 2023
Merged

[P013] Add setting for trigger-width and Combined mode #4442

merged 20 commits into from
Mar 29, 2023

Conversation

tonhuisman
Copy link
Contributor

@tonhuisman tonhuisman commented Dec 29, 2022 •
edited
Loading

Resolves #3857
Replaces #3157

Features:

  • Add a setting to configure the trigger-width for starting a measurement. Range 10..20 usec. Defaults to 10 (the current fixed width).
  • Add a setting to optionally disable repeating the last value event when using Mode = State. Removed/inhibited the added setting, but allow an Interval of 0, effectively suppressing any events.
  • Add Combined mode, as started in [P013_HCSR04] Add COMBINED mode #3157, also adding the missing bits.

NB: The added features are not available in the 1M and Minimal builds for .bin size reasons.

TODO:

  • Update/optimize plugin source and memory use
  • Update NewPing library, and include feature there also
  • Update documentation

@tonhuisman
[P013] Add setting for trigger-width
5e8a3d2
@tonhuisman
[Libs] Update NewPing library, add sanity check for triggerWidth …
8e4b319 
…argument
@tonhuisman
[P013] Reduce variable use, make State mode interval event optional
3b91f37
@tonhuisman
Merge branch 'mega' of https://github.com/letscontrolit/ESPEasy into …
4fab6a8 
…feature/P013-add-setting-for-trigger-width
@tonhuisman
[P013] Update documentation with added setting
4ffc21f
@tonhuisman
[P013] Update documentation with 'hidden' setting for Mode=State
a23cd43
@tonhuisman
Merge branch 'mega' into feature/P013-add-setting-for-trigger-width
1451bd3
@tonhuisman
Merge branch 'mega' of https://github.com/letscontrolit/ESPEasy into …
651079a 
…feature/P013-add-setting-for-trigger-width
@tonhuisman
[Lib] NewPing limit max trigger-width to 20 usec (wide enough)
1f7045a
@tonhuisman
[P013] Reduce plugin size (disable added features and log for 1M builds)
817b818
@tonhuisman
[P013] Update documentation with adjusted 20 usec setting
d40b8d5
@tonhuisman
Merge branch 'mega' into feature/P013-add-setting-for-trigger-width
21ebb55
@tonhuisman
[P013] Add Combined mode, as started in letscontrolit#3157
efc178d
@tonhuisman tonhuisman changed the title [P013] Add setting for trigger-width [P013] Add setting for trigger-width and Combined mode Jan 28, 2023
@TD-er TD-er merged commit d45e248 into letscontrolit:mega Mar 29, 2023
@tonhuisman tonhuisman deleted the feature/P013-add-setting-for-trigger-width branch March 29, 2023 20:18
@TD-er TD-er mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increasing the trigger for SR04M
2 participants
@tonhuisman @TD-er