Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boot flash mode for factory firmware #4199

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Fix boot flash mode for factory firmware #4199

merged 1 commit into from
Aug 15, 2022

Conversation

Jason2866
Copy link
Contributor

and set default to dout if none is set in boards manifest or in platformio.ini

Maybe fixes #4194

and set default to `dout` if none is set in boards manifest or in platformio.ini
@Jason2866 Jason2866 changed the title Fix boot flash mode Fix boot flash mode for factory firmware Aug 15, 2022
@TD-er TD-er merged commit bb6d6db into letscontrolit:mega Aug 15, 2022
@TD-er
Copy link
Member

TD-er commented Aug 15, 2022

I did merge this and also changed the board definitions for ESP32 boards to use QIO.
Changed the platform to use the git version, not the latest release.
Then performed a flash directly from the IDE, thus using esptool.py 4.2.1 as you've set in your platform
Flashing went well, but the ESP does seem to be using DIO:

image

@Jason2866 Jason2866 deleted the patch-1 branch August 15, 2022 13:35
@Jason2866
Copy link
Contributor Author

The second stage bootloader has decided to use dio ;-)

@TD-er
Copy link
Member

TD-er commented Aug 15, 2022

Meaning the bootloader detects the flash chip is not connected via QIO?

@Jason2866
Copy link
Contributor Author

Jason2866 commented Aug 15, 2022

Thats my understanding of the espressif docu. Probably "other" points have to met too to activate qio. I did not found specific infos for.
There is not just the "one" qio mode. Vendors use different implementations. So when the flash chip is not identified and does not match the list of known ones, qio is not enabled. dio is probably the fall back mode for all.

@TD-er
Copy link
Member

TD-er commented Aug 15, 2022

I guess so.
I will make a new PR including the sysinfo page showing the flash mode + the board changes I made.
So there will be no confusion or missing out on some details I may also have changed.
Then we can continue to discuss there.

@Jason2866
Copy link
Contributor Author

There is specific code for SPI flash chips https://github.com/espressif/esp-idf/blob/release/v4.4/components/spi_flash/Kconfig#L202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32&mega-20220809 AdaGFX helper issue
2 participants