Webserver port + P2P information exchange

[uzi18]

@TD-er something new :)

[TD-er]

Not sure if on the receiving side the message is accepted if its size differs from before.
Also on the receiving end you must make sure to realize this can be missing information.
Also there is some extended data version of this message if I'm not mistaken.

Maybe we should also introduce a version/revision of this message type?

[uzi18]

we send here 80 bytes and check only if 1st byte is 255 and packet len is more than 2 bytes
maybe we can use here build id on receiver site, but it is not a problem, because old builds not use these data

[TD-er]

But do they check for packet type based on the length of the packet?

[uzi18]

you mean rpieasy or older versions of espeasy?
on our side we have only check for length of packet but in fact it is always true because we send/receive always 80 bytes :)

[TD-er]

I thought there was some part of the p2p code that actually checks on the length of a packet.
But maybe the length is a parameter in the data itself.
Have to check the code as the correctness of my memory also has some variation.

[TD-er]

I've -by accident- come across this code myself as I needed to store node information received via another entry point and indeed it is a bit more data that's being sent.

I'm now creating a struct for it so we can just byte copy the whole struct at once and also extend with other features.

I will also add the port number as you added and maybe some more fields too.

[uzi18]

@TD-er so you want to merge this and extend with your work?
be aware about endiness of ints - arduino declares cpu as bigendian so can't store it directly thats why used here lowByte/highByte and makeWord

[uzi18]

also think about it and we should have these structs in src/DataStructs/...

[TD-er]

Already have it in src/DataStructs :)

[uzi18]

@TD-er and what about rest of webserver port stuff (not related to p2p)?

[uzi18]

@TD-er in ESPEasyStorage.ino line 155 we have test for build numbers with <= do i have to add there +1?
What do you think we can merge this PR or need to add something more?
Thinking about check also if mDNS sends also proper port ? not sure if it is possible but will check

[TD-er]

A test build is running and will be ready in about 10 - 15 minutes.

[TD-er]

A [est build: ESPEasy_mega-20200426-70-PR_3053.zip

[ghtester]

Just quickly tested:
Build:⋄ 20107 - Mega
System Libraries:⋄ ESP82xx Core 83166f94, NONOS SDK 2.2.2-dev(a58da79), LWIP: 2.1.2 PUYA support
Git Build:⋄
Plugin Count:⋄ 83 [Normal] [Testing]
Build Origin: Travis
Build Time:⋄ May 6 2020 01:01:06
Binary Filename:⋄ ESP_Easy_mega_20200506_test_beta_ESP8266_4M1M
Build Platform:⋄ Linux-4.15.0-91-generic-x86_64-with-glibc2.27
Git HEAD:⋄ HEAD

It looks to be working fine, tested with Webserver Port change to 81.

Thanks for the great job!

[TD-er]

I tested the links generated on the start page and it generated links to older units with random port numbers.
You should check against the build number in the p2p code to see if the other side was aware of sending a port number.

[uzi18]

ok will add one more test there

[uzi18]

@TD-er here you are :)

[uzi18]

@TD-er any news with this PR?

[TD-er]

I will add some of the code I made for the other project I work on and then I will merge it.

[uzi18]

thx, so now will try to find next bug/feature to resolve :)

[TD-er]

Preferably bugs, as I would like to add a release stamp on it.

[uzi18]

do you have a list of most wanted?

[TD-er]

Not really the most wanted, but since you've also been working on ESP32, and I haven't looked at this one, maybe you can have a look at #3079