Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/wifi stability #1325

Merged
merged 4 commits into from
Apr 27, 2018
Merged

Bugfix/wifi stability #1325

merged 4 commits into from
Apr 27, 2018

Conversation

TD-er
Copy link
Member

@TD-er TD-er commented Apr 27, 2018

Made wifi code much more less complex and upgraded core to 2.4.1

TD-er added 4 commits April 26, 2018 02:04
With static IP, the connection is lost frequently.
```
[core_2_4_1]
platform         = espressif8266@1.7.0

[common]
build_flags      = -D BUILD_GIT='"${env.TRAVIS_TAG}"'  ; ${compiler_warnings.build_flags}
                   -D PIO_FRAMEWORK_ARDUINO_LWIP2_HIGHER_BANDWIDTH
```
This may prevent issues with hostname resolving to 0.0.0.0.
@Oxyandy
Copy link

Oxyandy commented Apr 27, 2018

[Wifi] Avoid doing network communications when not connected.
Love the idea behind this, say an internal On Clock turns on relay, then a rule ends that early..
I have seen the device so busy that the rule is practically ignored and so device stays on..
Is very rare, but nasty things then happen..
Hoping this helps with that...

@TD-er
Copy link
Member Author

TD-er commented Apr 27, 2018

@Oxyandy
Processing rules with wifi disconnected is also high on my todo list.
It also makes a wall switch not respond when wifi is failing and that should not happen.
Also your strawberry field will drown when these things happen.

@Oxyandy
Copy link

Oxyandy commented Apr 27, 2018

I can not praise you enough..
In absolute awe of your efforts.. 💯
Please remember your family is number 1

@TD-er TD-er merged commit 697d20a into letscontrolit:mega Apr 27, 2018
@TD-er TD-er deleted the bugfix/wifi_stability branch April 27, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants