Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request.Add DS28EA00 chip chain feature support #4292

Closed
3dalex07 opened this issue Oct 10, 2022 · 13 comments · Fixed by #4310
Closed

Feature Request.Add DS28EA00 chip chain feature support #4292

3dalex07 opened this issue Oct 10, 2022 · 13 comments · Fixed by #4310
Labels
Category: Plugin Related to supported sensors Type: Feature Request Add a completely new feature (e.g. controller/plugin)

Comments

@3dalex07
Copy link

It is posible to add chain feature support for the Maxim DS28EA00 temperature sensor
maybe that library may help to do that
Thanks

@TD-er TD-er added Category: Plugin Related to supported sensors Type: Feature Request Add a completely new feature (e.g. controller/plugin) labels Oct 10, 2022
@TD-er
Copy link
Member

TD-er commented Oct 10, 2022

I have not yet seen this sensor myself.
Have to look into it to see if it can be used with other 1-wire sensors too.
For future reference, sensor info

@3dalex07
Copy link
Author

I have chain of that sensors 20 pck. It work with standart plugin P004 but sensors adresses reads randomly.

@TD-er
Copy link
Member

TD-er commented Oct 10, 2022

Do you have the pull-up resistor present?

@3dalex07
Copy link
Author

yes 2,2koM

@TD-er
Copy link
Member

TD-er commented Oct 10, 2022

OK, then I may have to order some to hook it up to the logic analyzer to see what may be happening here.

@TD-er
Copy link
Member

TD-er commented Oct 10, 2022

Wow, those are rather expensive.
Mouser asks 12 euro per piece and only starting at 10+ it drops to 7 euro.

@3dalex07
Copy link
Author

@3dalex07
Copy link
Author

I may connect my sensor chain to esp and give you access to it

@TD-er
Copy link
Member

TD-er commented Oct 11, 2022

I may connect my sensor chain to esp and give you access to it

I had to use my logic analyzer extensively to make the current Dallas code work.
So I don't think it will be very useful unless I have some of my own.

Anyway, I first have to check the datasheet to see if there might be some very obvious issue (e.g. more bits required to scan for an address or something similar)

@3dalex07
Copy link
Author

I have chain of that sensors 20 pck. It work with standart plugin P004 but sensors adresses reads randomly.

test it again / only adresses reads / temperature for all sensor 0 pullup 2.2k\

test only one connected sensor, adress reads but temperature show 0

@3dalex07
Copy link
Author

src/src/Helpers/Dallas1WireHelper.cpp
add line 56
case 0x42: return F("DS28EA00");
change line 392 to
if ((ROM[0] == 0x28) || (ROM[0] == 0x3b) || (ROM[0] == 0x22) || (ROM[0] == 0x42)) // DS18B20 or DS1825 or DS1822 or DS28EA00
now it reading temperature

@TD-er
Copy link
Member

TD-er commented Oct 19, 2022

Ah great!
So that's a very simple fix :)

TD-er added a commit to TD-er/ESPEasy that referenced this issue Oct 20, 2022
For future reference, see the [ID list](https://github.com/owfs/owfs-doc/wiki/1Wire-Device-List)
Fixes: letscontrolit#4292

Thanks @3dalex07 for debugging and handing the copy/paste fix.
@TD-er
Copy link
Member

TD-er commented Oct 20, 2022

Created a PR with essentially your suggested code changes in it: #4310
You could try the test build when ready, but I guess it can be merged as soon as that build has been completed without errors.

TD-er added a commit that referenced this issue Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Plugin Related to supported sensors Type: Feature Request Add a completely new feature (e.g. controller/plugin)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants