-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ArduinoIDE] ESPEasy_config.h outside src directory breaks build #4216
Comments
Can you test the PR #4217 ? |
Sure I'll try. But it seems there are a number of other changes/issues which makes it not compile anymore... I try to give feedback this week (before I'm gone with limited access for 3mths...) |
I can also merge it, since it should not break "PlatformIO builds" and I don't want to complicate other PRs. |
I think that would also make it easier for me to do a PR with the other changes and not mix it with this PR.. |
OK, will merge it. (that will close this issue, but I'm sure you will let me know if it is still a problem ;) ) |
[Build] Move include/ESPEasy_config.h to src/include (#4216)
Having
ESPEasy_config.h
outside thesrc
directory breaks the ArduinoIDE build which usesESPEasy/src
as root build dir.I suggest to keep all compile relevant files (all source and include files) within the
ESPEasy/src
directory to clearly differentiate between needed files for compiling and surrounding utilities for scripting/building, etc.As always IMHO...
The text was updated successfully, but these errors were encountered: