Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArduinoIDE] ESPEasy_config.h outside src directory breaks build #4216

Closed
clumsy-stefan opened this issue Aug 22, 2022 · 5 comments · Fixed by #4217
Closed

[ArduinoIDE] ESPEasy_config.h outside src directory breaks build #4216

clumsy-stefan opened this issue Aug 22, 2022 · 5 comments · Fixed by #4217

Comments

@clumsy-stefan
Copy link
Contributor

Having ESPEasy_config.h outside the src directory breaks the ArduinoIDE build which uses ESPEasy/src as root build dir.

I suggest to keep all compile relevant files (all source and include files) within the ESPEasy/src directory to clearly differentiate between needed files for compiling and surrounding utilities for scripting/building, etc.

As always IMHO...

@TD-er
Copy link
Member

TD-er commented Aug 22, 2022

Can you test the PR #4217 ?

@clumsy-stefan
Copy link
Contributor Author

Sure I'll try. But it seems there are a number of other changes/issues which makes it not compile anymore...

I try to give feedback this week (before I'm gone with limited access for 3mths...)

@TD-er
Copy link
Member

TD-er commented Aug 22, 2022

I can also merge it, since it should not break "PlatformIO builds" and I don't want to complicate other PRs.

@clumsy-stefan
Copy link
Contributor Author

I think that would also make it easier for me to do a PR with the other changes and not mix it with this PR..

@TD-er
Copy link
Member

TD-er commented Aug 22, 2022

OK, will merge it. (that will close this issue, but I'm sure you will let me know if it is still a problem ;) )

TD-er added a commit that referenced this issue Aug 22, 2022
[Build] Move include/ESPEasy_config.h to src/include (#4216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants