Merge pull request #22 from leroy-merlin-br/sniff/useless-variable

Add sniff to forbid useless variables on returns
leroy-merlin-br · Feb 13, 2019 · da69134 · da69134
2 parents 89b61cb + bfdbcd1
commit da69134
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/LeroyMerlin/ruleset.xml b/lib/LeroyMerlin/ruleset.xml
@@ -222,6 +222,8 @@
     </rule>
     <!-- Forbid duplicated variables assignments -->
     <rule ref="SlevomatCodingStandard.Variables.DuplicateAssignmentToVariable"/>
+    <!-- Forbid useless variables -->
+    <rule ref="SlevomatCodingStandard.Variables.UselessVariable"/>
     <!-- Forbid spaces around square brackets -->
     <rule ref="Squiz.Arrays.ArrayBracketSpacing"/>
     <!-- Force array declaration structure -->

diff --git a/tests/expected/example-class.php b/tests/expected/example-class.php
@@ -81,9 +81,7 @@ public function mangleBar(int $length): void
 
     public static function getMinorVersion(): int
     {
-        $version = self::VERSION;
-
-        return $version;
+        return self::VERSION;
     }
 
     public static function getTestCase(): TestCase

diff --git a/tests/expected_report.txt b/tests/expected_report.txt
@@ -23,7 +23,7 @@ tests/input/useless-semicolon.php                     4       0
 ----------------------------------------------------------------------
 A TOTAL OF 129 ERRORS AND 0 WARNINGS WERE FOUND IN 17 FILES
 ----------------------------------------------------------------------
-PHPCBF CAN FIX 115 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
+PHPCBF CAN FIX 116 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
 ----------------------------------------------------------------------