refactor: changed types and annotations 3 #247
+1,619
−1,225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoFerrazfs
previously approved these changes
Oct 7, 2024
Base automatically changed from
refactor/change-types-and-annotations-2
to
v3.x
October 9, 2024 16:52
orlandocavassani
previously approved these changes
Oct 11, 2024
| */ | ||
| protected function referencesMany(string $entity, string $field, bool $cacheable = true): CursorInterface | ||
| protected function referencesMany(string $entity, string $field, bool $cacheable = true) |
There was a problem hiding this comment.
Return type is missing here
| */ | ||
| protected function embedsMany(string $entity, string $field): CursorInterface | ||
| protected function embedsMany(string $entity, string $field) |
There was a problem hiding this comment.
Return type is missing here, too.
| */ | ||
| private function getDocumentFromCache(ModelInterface $entityInstance, string $referencedId): mixed | ||
| private function getDocumentFromCache(ModelInterface $entityInstance, string $referencedId) |
There was a problem hiding this comment.
Return type is missing here, too.
flaviozantut
approved these changes
Oct 15, 2024
| @@ -267,7 +209,7 @@ public function getCollectionName(): string | |||
| throw new NoCollectionNameException(); | |||
| } | |||
|
|
|||
| return $this->getSchema()->collection; | |||
| return $this->collection ?: $this->getSchema()->collection; | |||
There was a problem hiding this comment.
Suggested change
| return $this->collection ?: $this->getSchema()->collection; | |
| return $this->getSchema()->collection; |
I think it's better to keep the actual implementation because getSchema function can return a schema from fields too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Este PR é o terceiro de um serie de PRs que tem por objetivo adicionar padroes de codigo ao mongolid.
As adições realizadas aqui estão sendo desmebradas do PR:
https://github.com/leroy-merlin-br/mongolid/pull/209/files#diff-44c6c764ba381928e3221e4690c18dc0fe596311af5b123d5d2089ffc4db52af
E são testadas no projeto : https://github.com/JoaoFerrazfs/Mongo-PHP-Docker_BaseProject