Update mongolid version 3 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djonasm
force-pushed
the
chore/update-mongolid-version-3
branch
from
292032d to
5d9ecd4
Compare
djonasm
force-pushed
the
chore/update-mongolid-version-3
branch
from
5d9ecd4 to
7c050fb
Compare
orlandocavassani
previously requested changes
May 4, 2022
| */ | ||
| public function setSecretAttribute($value) | ||
| public function setSecretAttribute($value): string |
There was a problem hiding this comment.
Does Mongolid use the return of a setter to fill a field?
| $client->fill([ | ||
| 'secret' => $client->secret, | ||
| ], true); | ||
| $client->setSecretAttribute($client->secret); |
There was a problem hiding this comment.
Using fill is more intuitive than calling setter directly, and works with the syntax $client->secret = 'some-secret';. I would use fill.
But, if you don't want to change it, you'll have to fix the ClientCommand and look for other necessary changes.
diegofelix
approved these changes
Jul 15, 2022
henrique221
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.