fix(dialogs): Focus on the dialog buttons after displaying an alert or confirm #244
Conversation
vitortalaia
requested review from
fabricionaweb,
willamesoares and
felipesoares6
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 409 413 +4
=====================================
+ Hits 409 413 +4
Continue to review full report at Codecov.
|
|
|
||
| instance.showConfirm() | ||
|
|
||
| expect(spy.calledOnce).to.be.true |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression no-unused-expressions
|
|
||
| instance.showAlert() | ||
|
|
||
| expect(spy.calledOnce).to.be.true |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression no-unused-expressions
|
|
||
| instance.showConfirm() | ||
|
|
||
| expect(spy.calledOnce).to.be.true |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression no-unused-expressions
|
|
||
| instance.showAlert() | ||
|
|
||
| expect(spy.calledOnce).to.be.true |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression no-unused-expressions
vitortalaia
force-pushed
the
fix/focus-on-alert-or-confirm-modals
branch
from
8e4261d to
ec429f2
Compare
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Oops! Something went wrong! :(
ESLint couldn't find the plugin "eslint-plugin-chai-friendly". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-chai-friendly is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm i eslint-plugin-chai-friendly@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.
| beforeEach(() => { | ||
| instance.modal = { | ||
| show () {}, | ||
| $content: $('<div><button data-alert-button>Ok</button></div>') |
There was a problem hiding this comment.
só 💅 msm mas não vale passar isso pra uma fixture?
There was a problem hiding this comment.
Cheguei a pensar nisso, mas vi que em nenhum outro lugar precisava de nada do DOM, aí deixei só aqui mesmo
The focus was still placed on the element that triggered the dialog, causing the opening of multiple dialogs when hitting the
enterkeyAlert
Before
After
Confirm
Before
After