Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing whitespace from output when there are no changes #118

Closed
inakianduaga opened this issue Aug 28, 2018 · 1 comment · Fixed by #153
Closed

Remove trailing whitespace from output when there are no changes #118

inakianduaga opened this issue Aug 28, 2018 · 1 comment · Fixed by #153
Labels
enhancement

Comments

@inakianduaga
Copy link

Currently, if there are no labeled PRs since the last commit, lerna-changelog will output 3 lines of whitespace

➜  as24-custom-events git:(changelog_generation) ✗ npx lerna-changelog


➜  as24-custom-events git:(changelog_generation) ✗

this makes it annoying when we want to automate updating the CHANGELOG automatically via CI because the file will grow even if there are no changes. Should be simple enough to run a .trim to the output
@Turbo87
Copy link
Contributor

Turbo87 commented Aug 28, 2018

pull requests welcome 😉

shrikanthkr added a commit to shrikanthkr/lerna-changelog that referenced this issue Oct 12, 2019
@shrikanthkr
Addressing issue lerna#118
c2f2ae1 
enhancement: Fix mardown-rendered to add empty lines only when release commits are present. It return an empty sting in case of not commits it returns an empty stirng
@shrikanthkr shrikanthkr mentioned this issue Oct 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@Turbo87 @inakianduaga