Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates, pointed to rc1 version of crates #3

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

ogghead
Copy link
Contributor

@ogghead ogghead commented Nov 4, 2024

Hi folks! Thank you for all the excellent work creating this integration :) Currently, main branch code does not build as it relies on changes in the Leptos repository that are not yet released in a tagged crate version.

This version:

  1. Updates cargo.toml to point to git repository version of any_spawner temporarily + rc1 versions of other crates
  2. Adds mapping for OptionalParam
  3. Reexports http::StatusCode and any_spawner::Executor (temporarily) for convenience
  4. Many automatic linting changes -- I have my IDE run clippy --all -- please let me know if these formatting changes are undesirable

Signed-off-by: Darwin Boersma <darwin@sadlark.com>
Signed-off-by: Darwin Boersma <darwin@sadlark.com>
@ogghead ogghead changed the title Minor updates, pointed to git versions of packages to build deps until rc1 Minor updates, pointed to rc1 version of crates Nov 5, 2024
Signed-off-by: Darwin Boersma <darwin@sadlark.com>
Copy link
Collaborator

@raskyld raskyld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

On the point of CI/CD, anyway, I will need to set it up to stay consistent with other repository of the organisation.

Thanks for your contributions ❤️

@ogghead
Copy link
Contributor Author

ogghead commented Nov 7, 2024

Thank you for checking this :) I don't appear to have permissions to merge it unfortunately

@raskyld raskyld merged commit 249cf88 into leptos-rs:main Nov 7, 2024
@ogghead ogghead deleted the pre-rc1-building branch November 8, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants