Skip to content

Commit

Permalink
Remove unnecessary saveOptions call
Browse files Browse the repository at this point in the history
This call did trigger an endless loop which called `devTool.saveOptions` as many times as we could, till the `MAX_WRITE_OPERATIONS_PER_MINUTE` error stopped us.
Because, when we alter the checkbox with `detailPanelShow.checked = false` the eventlistener on the checkbox will save the new state and call our function - no need to alter the devTool options again
  • Loading branch information
leonvogt committed Jun 3, 2024
1 parent 659fb04 commit 90cd9a5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/popup.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ const maybeHideDetailPanel = () => {

if (!showDetailPanel) {
detailPanelShow.checked = false
devTool.saveOptions({ detailPanel: { ...devTool.options.detailPanel, show: false } })
toggleDetailPanelInputs(false)
}
}
Expand Down

0 comments on commit 90cd9a5

Please sign in to comment.