-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix output error when parallel_requests > 1 and supports_multiple_generations is False #864
fix output error when parallel_requests > 1 and supports_multiple_generations is False #864
Conversation
fcd7bce
to
bac3634
Compare
This branch fixes error:
|
bac3634
to
06320b0
Compare
Signed-off-by: Arjun Krishna <arjunkrishna1306@gmail.com>
Signed-off-by: Arjun Krishna <arjunkrishna1306@gmail.com>
06320b0
to
4cfe201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. It looks like there is an issue around outputs
being built when parallel_requests > 1
, because outputs should be a list of strings
and None
s, but the output of _call_model
(a list of strings
/none
s) is appended to it.
Recommendations:
- Rename this PR to be about
parallel_requests
- Check that
_call_model
is returning just one result at a time in thePool
content - Move the tests out of
test_nim
parallel_requests
and supports_multiple_generations
is False
parallel_requests
and supports_multiple_generations
is FalseSigned-off-by: Arjun Krishna <arjunkrishna1306@gmail.com>
Signed-off-by: Arjun Krishna <arjunkrishna1306@gmail.com>
Signed-off-by: Arjun Krishna <arjunkrishna1306@gmail.com>
Co-authored-by: Jeffrey Martin <jmartin@Op3n4M3.dev> Signed-off-by: Arjun Krishna <45014214+arjun-krishna1@users.noreply.github.com>
Signed-off-by: Arjun Krishna <arjunkrishna1306@gmail.com>
Changes addressed in 8187035-3551a34
Resolve: #861 (comment)
parallel_requests
> 1TypeError: expected string or bytes-like object, got 'list'