Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nfsaas 1875 swagger update #12

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Nfsaas 1875 swagger update #12

merged 2 commits into from
Mar 13, 2019

Conversation

leonardbf
Copy link
Owner

Still in preview - breaking changes are not considered applicable.

Changes:

  • Inclusion of status code (due to sync).
  • Inclusion of account and volume property (AD and export policy)
  • Inclusion of missing capacityPool patch properties
  • ServiceLevel name change
  • Changed resourceGroup to resourceGroupName (correct naming for CLI features)

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@leonardbf leonardbf merged commit 0845526 into master Mar 13, 2019
@leonardbf leonardbf deleted the NFSAAS-1875-swagger-update branch March 13, 2019 21:18
leonardbf added a commit that referenced this pull request Mar 21, 2019
* NFSAAS-1505 minor update and validation fixes

* NFSAAS-1505 bring in line with RP

Put (and patch) for snapshots.
Service level definition changes.

* NFSAAS-1505 correct resource reference and limits

* NFSAAS-1505 resource and property changes

Incorrect pool resource reference
Name elements of property not required
Correction to return status code

* NFSAAS-1505 status codes

* NFSAAS-1505 tidy up examples

* NFSAAS-1505 tidy up examples

* NFSAAS-1644 remove mt get and add put status code

* NFSAAS-1644 remove mt get and add put status code

* NFSAAS-1875 update to R3.5 standard

* NFSAAS-1875 Update to R3.5 Standard (#11)

* Nfsaas 1875 swagger update (#12)

* NFSAAS-1875 Update to R3.5 Standard

* NFSAAS-1875 update to R3.5 standard

* Nfsaas 1875 swagger update (#13)

* NFSAAS-1875 Update to R3.5 Standard

* NFSAAS-1875 update to R3.5 standard

* NFSAAS-1875 updated from review comments
leonardbf added a commit that referenced this pull request Apr 17, 2019
* NFSAAS-1505 minor update and validation fixes

* NFSAAS-1505 bring in line with RP

Put (and patch) for snapshots.
Service level definition changes.

* NFSAAS-1505 correct resource reference and limits

* NFSAAS-1505 resource and property changes

Incorrect pool resource reference
Name elements of property not required
Correction to return status code

* NFSAAS-1505 status codes

* NFSAAS-1505 tidy up examples

* NFSAAS-1505 tidy up examples

* NFSAAS-1644 remove mt get and add put status code

* NFSAAS-1644 remove mt get and add put status code

* NFSAAS-1875 update to R3.5 standard

* NFSAAS-1875 Update to R3.5 Standard (#11)

* Nfsaas 1875 swagger update (#12)

* NFSAAS-1875 Update to R3.5 Standard

* NFSAAS-1875 update to R3.5 standard

* Nfsaas 1875 swagger update (#13)

* NFSAAS-1875 Update to R3.5 Standard

* NFSAAS-1875 update to R3.5 standard

* NFSAAS-1875 updated from review comments

* NFSAAS-1875 small correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant