Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prerequisites Node.js >= 16.0.0 and npm >= 8.0.0 #322

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

theoludwig
Copy link
Member

@theoludwig theoludwig commented Nov 6, 2021

What type of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Documentation
  • Not Sure?

Does this PR introduce breaking changes?

  • Yes
  • No

BREAKING CHANGE: Minimum supported Node.js v16.0.0 and npm v8.0.0

Description:

  • Update Node.js and npm
  • Usage of the new package-lock.json
  • Update Dockerfile to work with Node.js v16

@theoludwig theoludwig requested a review from louistiti November 6, 2021 14:46
@theoludwig theoludwig self-assigned this Nov 6, 2021
@theoludwig theoludwig force-pushed the nodejs-16-npm-8 branch 2 times, most recently from cc9629c to c17b812 Compare November 6, 2021 18:57
BREAKING CHANGE: minimum supported Node.js v16.0.0 and npm v8.0.0
@louistiti
Copy link
Member

LGTM and it is clean. From now on we will stop using leon-ai/leon-ci-image as it creates some permission conflicts with node:16-alpine.

@louistiti louistiti merged commit 2f66f1c into develop Nov 7, 2021
@theoludwig theoludwig deleted the nodejs-16-npm-8 branch November 7, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants