Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects: Improve outlook of each project section #4

Closed
leohuynguyenchi opened this issue Apr 19, 2024 · 20 comments
Closed

Projects: Improve outlook of each project section #4

leohuynguyenchi opened this issue Apr 19, 2024 · 20 comments
Assignees

Comments

@leohuynguyenchi
Copy link
Owner

In the Projects tab, each project sections are displayed.

Suggestions:

  • Insert a color layer/shape behind each section to improve their look
@leohuynguyenchi leohuynguyenchi converted this from a draft issue Apr 19, 2024
@PipoAT PipoAT self-assigned this Apr 19, 2024
@PipoAT PipoAT moved this from Backlog to Ready in Open Source Project Kanban Apr 19, 2024
@PipoAT
Copy link
Collaborator

PipoAT commented Apr 19, 2024

I will take this and work on it

@PipoAT PipoAT moved this from Ready to In progress in Open Source Project Kanban Apr 19, 2024
@leohuynguyenchi
Copy link
Owner Author

Sounds good! Let me know if you need some more clarity or brainstorming

@PipoAT
Copy link
Collaborator

PipoAT commented Apr 19, 2024

image

Okay, sounds good! We may need to fix the html or existing css on this as well as for some reason not all the cards on the project page are consistent.

I added a div tag with the following so that it would produce what I got above

image

@leohuynguyenchi
Copy link
Owner Author

Wow I see...that's some good progress! Yeah we can dig deep into that. I needa watch some videos for SCSS and hugo stuffs

@PipoAT
Copy link
Collaborator

PipoAT commented Apr 20, 2024

scss acts the same way as css

@PipoAT
Copy link
Collaborator

PipoAT commented Apr 20, 2024

I see minor differences between the two

@PipoAT
Copy link
Collaborator

PipoAT commented Apr 20, 2024

I looked into the inconsistencies in the card layout. It is a result of the length of the descriptions, thus each card's height is dynamically generated and different from one another

@PipoAT
Copy link
Collaborator

PipoAT commented Apr 20, 2024

This is an improvement though. Thoughts?

Image

@leohuynguyenchi
Copy link
Owner Author

Looks better to me! I don't have any ideas of how to improve it more but we can leave it to "In Review" so we can review it later. Good work man!

@leohuynguyenchi
Copy link
Owner Author

I just changed the layout of project cards to look like this:

Image

@PipoAT
Copy link
Collaborator

PipoAT commented Apr 21, 2024

That looks so much better. Should we center everything within each card?

@PipoAT
Copy link
Collaborator

PipoAT commented Apr 21, 2024

Thoughts? I pushed the text alignment to dev

Image

@leohuynguyenchi
Copy link
Owner Author

That looks great! It would be greater if there's a way to center the color border. I guess we can use alignment center for it

Image

@PipoAT
Copy link
Collaborator

PipoAT commented Apr 21, 2024

That would be ideal. How is the color border attached to the project card?

@leohuynguyenchi
Copy link
Owner Author

I'm not sure...Doing some investigation on Chrome dev tools now

@PipoAT
Copy link
Collaborator

PipoAT commented Apr 21, 2024

From what I could tell, my suspicion is that it is attached to either the name of the project or is part of some div tag I cant find for some reason

@leohuynguyenchi
Copy link
Owner Author

Oh I got it, it's the width property of .border element in SCSS:

Image

@leohuynguyenchi
Copy link
Owner Author

Just pushed my changes to dev

@PipoAT
Copy link
Collaborator

PipoAT commented Apr 21, 2024

Ohhh perfect! Are we good to close this issue and move to done then?

@leohuynguyenchi
Copy link
Owner Author

Yes, we're done with this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants