manager: Fix leo-project/leofs/issues/695 #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocchira
requested changes
Apr 11, 2017
| @@ -1099,14 +1099,13 @@ bucket_by_access_key(Buckets) -> | |||
| BucketStr = binary_to_list(Bucket1), | |||
| PermissionsStr = leo_s3_bucket:aclinfo_to_str(Permissions1), | |||
|
|
|||
| RedOptions = leo_redundant_manager_api:get_options(), | |||
| {ok, RedOptions} = leo_redundant_manager_api:get_options(), | |||
There was a problem hiding this comment.
I tried leofs-adm get-bucket 05236 with one bucket named test and got the result as below.
$ ./leofs-adm get-bucket 05236
bucket | permissions | redundancy method | created at
---------+------------------+--------------------------+---------------------------
test | Me(full_control) | copy, {n:1, w:1, r:1, d: | 2017-04-11 09:24:43 +0900The column redundancy method for test is not fully displayed so need to pad additional spaces for it.
There was a problem hiding this comment.
Note: leofs-adm get-buckets looks good.
$ ./leofs-adm get-buckets
cluster id | bucket | owner | permissions | redundancy method | created at
-------------+----------+-------------+------------------+------------------------------+---------------------------
leofs_1 | test | _test_leofs | Me(full_control) | copy, {n:1, w:1, r:1, d:1} | 2017-04-11 09:24:43 +0900There was a problem hiding this comment.
@mocchira In the next step, I'll fixed the output format.
There was a problem hiding this comment.
@yosukehara OK. I'll file it as another issue.
mocchira
approved these changes
Apr 11, 2017
This was referenced Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed #695