Fix Large Object Handler Memory Issue #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocchira
requested changes
Jan 11, 2017
| Error -> | ||
| ?warn("invoke/5", [{error, Error}]), |
There was a problem hiding this comment.
This may cause logging burst problem when clients try to access a file that doesn't exist as I previously mentioned at another issue.
as you know, handle_error already has produced warning in case badrpc and unknown one and
IIRC the caller leo_gateway_s3_api logged in case unavailable so removing this line looks good to me.
There was a problem hiding this comment.
thanks for you comment, I have updated the PR
mocchira
approved these changes
Jan 11, 2017
|
@windkit Reviewed and merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch to rpc:call and gen_server:call with {timeout, infinity}
Related Issue
leo-project/leofs#570