Refactor S3 components into common module for reuse #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remaining transformers into common. Unit testing. Removing scala testcontainers lib from S3 and reusing the test-common S3 test containers Extract shared code to cloud-common Renaming some common things which shouldn't have S3 in their name GCP Config WTD Clean up, reduce tech debt, remove duplicated functionality, avoid weak string referencing Updating references to S3 in common module
davidsloan
changed the title
FPerezP
approved these changes
Nov 7, 2023
stheppi
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining transformers into common. Unit testing. Removing scala testcontainers lib from S3 and reusing the test-common S3 test containers Extract shared code to cloud-common
Renaming some common things which shouldn't have S3 in their name GCP Config WTD
Clean up, reduce tech debt, remove duplicated functionality, avoid weak string referencing Updating references to S3 in common module