Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading CRD conditions #967

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Fix reading CRD conditions #967

merged 1 commit into from
Sep 25, 2020

Conversation

nevalla
Copy link
Contributor

@nevalla nevalla commented Sep 25, 2020

This PR checks that CRD has status property before reading conditions from it.

Fixes #882.

Signed-off-by: Lauri Nevala lauri.nevala@gmail.com

Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
@nevalla nevalla added area/ui bug Something isn't working labels Sep 25, 2020
@nevalla nevalla requested a review from a team September 25, 2020 06:33
@nevalla nevalla added this to the 3.6.5 milestone Sep 25, 2020
Copy link
Contributor

@ixrock ixrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nevalla nevalla merged commit 265aa41 into master Sep 25, 2020
@nevalla nevalla deleted the fix/crd-conditions-reading branch September 25, 2020 09:59
This was referenced Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crash on CRD list: TypeError: Cannot read property 'conditions' of undefined
2 participants