Helm components should always use version information #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Malton <sebastian@malton.name>
nevalla
reviewed
Sep 24, 2020
nevalla
approved these changes
Sep 24, 2020
Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
fixes #905 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name
fixes #853
Helm seems to either want
--develor a--versionto be set when listing items. Since we are already using version information in some places I felt it would be better to use it in all places.This PR also refactors
HelmChartDetailsso that the promises are not called in non async functions and then not awaited. This was done to prevent the two occurrences ofUnhandledPromiseRejections.