fix Notifications blocking items not visually under them from being interacted with #915
Conversation
|
I think the integration test failure is a real issue. This is what I see when running those manually. |
…nteracted with Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
fix-notifications-blocking-buttons
branch
from
06b2417 to
fb35575
Compare
|
This is really weird. It seems like the follow css was the "reason" why the tests were failing: #app {
> * {
height: inherit;
}
}Namely, once I put it back they started to pass locally. |
| @@ -3,10 +3,11 @@ | |||
|
|
|||
| position: absolute; | |||
| right: 0; | |||
| bottom: 0; | |||
| top: 0; | |||
There was a problem hiding this comment.
It would be nice to consider keeping bottom: high-above-button to locate the notification message box at the bottom-right corner. Which is a walk round of solving issue #842 as well. In that issue, the draggable-top div is outside the iframe which contains the notification box that make it difficult to find an ideal solution to have both text selection and drag features at the same time.
It is quite common to have notification on the bottom right as well.
There was a problem hiding this comment.
Notifications currently list top to bottom, so that placement wouldn't help much. I played around with not using padding (and trying to use margin instead) so that the visually empty space around the notifications can be clicked through. #842 needs other work not just this so I don't think that its work should bleed into this PR.
fixes #847
Signed-off-by: Sebastian Malton sebastian@malton.name