Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make download dir option consistent with other settings #875

Merged
merged 3 commits into from
Sep 23, 2020

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Sep 14, 2020

Signed-off-by: Sebastian Malton smalton@mirantis.com

fixes #862

Signed-off-by: Sebastian Malton <smalton@mirantis.com>
@Nokel81 Nokel81 requested a review from nevalla September 14, 2020 19:00
@Nokel81 Nokel81 self-assigned this Sep 14, 2020
@nevalla
Copy link
Contributor

nevalla commented Sep 16, 2020

Please could you make also Path to Kubectl binary follow the same style.

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 requested a review from nevalla September 17, 2020 15:11
@Nokel81 Nokel81 added bug Something isn't working area/ui labels Sep 17, 2020
Co-authored-by: Lauri Nevala <lauri.nevala@gmail.com>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 force-pushed the fix-download-dir-option branch from 0aa33be to 8166625 Compare September 18, 2020 13:59
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nevalla nevalla changed the title make download dir option consitent with other settings Make download dir option consistent with other settings Sep 23, 2020
@nevalla nevalla added this to the 3.6.5 milestone Sep 23, 2020
@Nokel81 Nokel81 merged commit b88c0d4 into lensapp:master Sep 23, 2020
This was referenced Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Directory for binaries" input field not consistent with other fields
2 participants