Extensions-api: initial hello-world example #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ixrock
added
area/extension
jakolehm
reviewed
Sep 8, 2020
| console.log('EXAMPLE EXTENSION: ACTIVATE', this.getMeta()) | ||
| const { dynamicPages } = this.runtime; | ||
|
|
||
| this.unRegisterPage = dynamicPages.register({ |
There was a problem hiding this comment.
Maybe the API should be something like:
this.registerPage({
type: DynamicPageType.CLUSTER,
path: "/extension-example",
// ...
})and LensExtension would automatically do unregister etc housekeeping.
Nokel81
reviewed
Sep 8, 2020
| import React from "react"; | ||
| import path from "path"; | ||
|
|
||
| let extension: ExampleExtension; // todo: provide instance from context |
There was a problem hiding this comment.
Couldn't this be achieved by a static method on ExampleExtension?
There was a problem hiding this comment.
This solution was temporary
nevalla
changed the base branch from
feature/extensions_api
to
extensions-api
…n: menu icon + page Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
…mo-only) Signed-off-by: Roman <ixrock@gmail.com>
nevalla
force-pushed
the
feature/extensions-api/hello-world
branch
from
40d3ad0 to
966aa38
Compare
Signed-off-by: Roman <ixrock@gmail.com>
jakolehm
approved these changes
Sep 9, 2020
|
Tests are still failing... |
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new icon and page in cluster-view