Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not crash when opening details of a helm release #7697

Merged
merged 2 commits into from
May 9, 2023

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented May 8, 2023

  • Switch to using RequestChannel instead of LensProxy for better type safety.

fixes #7617

- Switch to using RequestChannel instead of LensProxy for better
  type safety

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added bug Something isn't working area/helm Helm charts and releases labels May 8, 2023
@Nokel81 Nokel81 added this to the 6.5.0 milestone May 8, 2023
@Nokel81 Nokel81 requested a review from a team as a code owner May 8, 2023 19:38
@Nokel81 Nokel81 requested review from aleksfront and gabriel-mirantis and removed request for a team May 8, 2023 19:38
@Nokel81
Copy link
Collaborator Author

Nokel81 commented May 8, 2023

The benefit of moving to using RequestChannels means that if the types are changed on one side it means that a compiler error will be caused everywhere else.

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 merged commit 6167ad2 into master May 9, 2023
@Nokel81 Nokel81 deleted the fix-helm-releases-crash branch May 9, 2023 13:28
This was referenced May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm charts and releases bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crash opening Helm release
2 participants