Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make package-locks less volatile #7677

Merged
merged 8 commits into from
May 4, 2023
Merged

Make package-locks less volatile #7677

merged 8 commits into from
May 4, 2023

Conversation

Iku-turso
Copy link
Contributor

Notable:

  1. Specific version of npm is enforced by using engines in package.json and .npmrc.
  2. npm scripts for installing now acquire the correct version of NPM independently.
  3. GitHub actions are also consolidated to use the specific version.
  4. As bonus, added a quality-of-life script for devs to all:reinstall.

@Iku-turso Iku-turso added the chore label May 4, 2023
@Iku-turso Iku-turso added this to the 6.5.0 milestone May 4, 2023
@Iku-turso Iku-turso requested a review from a team as a code owner May 4, 2023 10:54
@Iku-turso Iku-turso requested review from ixrock and aleksfront and removed request for a team May 4, 2023 10:54
Iku-turso and others added 8 commits May 4, 2023 13:55
@Iku-turso @gabriel-mirantis
chore: Add npm-script to nuke and reinstall dependencies
5f5a8da 
Co-authored-by: Gabriel <gaccettola@mirantis.com>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
@Iku-turso @gabriel-mirantis
chore: Enforce a specific version of NPM to make package-locks not vary
b8349d5 
Co-authored-by: Gabriel <gaccettola@mirantis.com>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
@Iku-turso @gabriel-mirantis
chore: Make script "all:install" use the fixed version of npm
1b314fe 
Co-authored-by: Gabriel <gaccettola@mirantis.com>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
@Iku-turso @jansav
chore: Update package-lock
7220487 
There's supposedly something between devs causing volatility in the
package-lock. Needs some investigation.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
@Iku-turso
chore: Make ci "npm install" using correct version of NPM
3e976de 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
@Iku-turso
chore: Make ci "npm ci" using correct version of NPM
275da37 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
@Iku-turso @gabriel-mirantis
chore: Revert non-working way to specify npm version in ci
09acf8f 
This reverts commit 1232445.

Co-authored-by: Gabriel <gaccettola@mirantis.com>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
@Iku-turso
chore: Try if CI works with an alternate way of specifying npm version
39c66d4 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
@Iku-turso Iku-turso force-pushed the make-package-locks-less-volatile branch 2 times, most recently from a86272e to 39c66d4 Compare May 4, 2023 11:15
@gabriel-mirantis gabriel-mirantis merged commit 1b30b50 into master May 4, 2023
@gabriel-mirantis gabriel-mirantis deleted the make-package-locks-less-volatile branch May 4, 2023 12:23
@k8slens-bot k8slens-bot mentioned this pull request May 4, 2023
Merged
@Nokel81 Nokel81 mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-mirantis gabriel-mirantis gabriel-mirantis approved these changes

@ixrock ixrock Awaiting requested review from ixrock ixrock is a code owner automatically assigned from lensapp/lens-ide

@aleksfront aleksfront Awaiting requested review from aleksfront aleksfront is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Iku-turso @gabriel-mirantis