Export getPodsByOwnerId to extension API
#7225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
reviewed
Feb 23, 2023
| } | ||
|
|
||
| export class CronJobStore extends KubeObjectStore<CronJob, CronJobApi> { | ||
| constructor(protected readonly dependencies: Dependencies, api: CronJobApi, opts?: KubeObjectStoreOptions) { | ||
| super(dependencies, api, opts); | ||
| } | ||
|
|
||
| getChildPods(cronJob: CronJob): Pod[] { | ||
| return this.dependencies.getPodsByOwnerId(cronJob.getId()); |
There was a problem hiding this comment.
Wouldn't it be better to export getPodsByOwnerId to the extension API?
apialaviiva
changed the title
apialaviiva
force-pushed
the
resource-details-vulnerabilities
branch
from
ab15c39 to
613d25e
Compare
apialaviiva
force-pushed
the
resource-details-vulnerabilities
branch
from
613d25e to
34c2e87
Compare
apialaviiva
requested review from
ixrock and
aleksfront
and removed request for
a team
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
resource-details-vulnerabilities
branch
from
34c2e87 to
a5f5e7a
Compare
Nokel81
approved these changes
Mar 24, 2023
Nokel81
changed the title
getPodsByOwnerId to extension API
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.