-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mechanism for users to specify accessible namespaces #702
Conversation
348a23a
to
962797b
Compare
962797b
to
7f1208b
Compare
@nevalla changed base to master |
a1f73b3
to
604db32
Compare
src/renderer/components/+cluster-settings/components/cluster-accessible-namespaces.tsx
Outdated
Show resolved
Hide resolved
@Nokel81 Do you have real-world example of a test case for a user without namespace listing rights? Currently I am unable to create such a user. Tested with
and
With this settings the results are actually really strange: namespaces wouldn't listed no matter what's included in the |
@aleksfront Sorry I do not have a testing case, I am going off of what what the initial issue said |
d8eda18
to
a27b50e
Compare
a27b50e
to
5d4b767
Compare
Generally looking good and I was able to see those namespaces that I was set in cluster settings. Related to configuring namespaces, can we have some hint that editable list that it requires pressing enter to add an item? Also, probably out of scope of this PR, but after configuring allowed namespaces we should somehow send a signal to the dashboard to update namespaces list. |
@nevalla Good idea, when I close this I will make a follow up ticket. @aleksfront Given Lauri's review, can you accept this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor i18n comments!
src/renderer/components/+cluster-settings/components/cluster-accessible-namespaces.tsx
Outdated
Show resolved
Hide resolved
…them. This is generally useful for when the user doesn't have permission to list the namespaces. - Add new component "EditableList" which provides a simple way to display a list of items that can be added too. - Add the ClusterAccessibleNamespaces to the GeneralClusterSettings Signed-off-by: Sebastian Malton <smalton@mirantis.com>
Signed-off-by: Sebastian Malton <smalton@mirantis.com>
Signed-off-by: Sebastian Malton <smalton@mirantis.com>
Signed-off-by: Sebastian Malton <smalton@mirantis.com>
Signed-off-by: Sebastian Malton <smalton@mirantis.com>
Signed-off-by: Sebastian Malton <smalton@mirantis.com>
cc619e4
to
bce0f94
Compare
The namespaces which are accessible to them. This is generally useful for when the user doesn't have permission to list the namespaces.
Add new component "EditableList" which provides a simple way to
display a list of items that can be added too.
Add the ClusterAccessibleNamespaces to the GeneralClusterSettings
Signed-off-by: Sebastian Malton smalton@mirantis.com
closes #486
This is a draft PR because it should be targetingmaster
butvue_react_migration
hasn't been merged to master yet.