Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal tab auto-close fixes #314

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Terminal tab auto-close fixes #314

merged 1 commit into from
Apr 28, 2020

Conversation

jakolehm
Copy link
Contributor

Fixes bugs introduced in #294.

  • close only on disconnect
  • leave terminal open for 15s if process exits with an error code (so that user can see the error)

@jakolehm
terminal tab auto-close fixes
3d26664 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added the bug Something isn't working label Apr 26, 2020
@jakolehm jakolehm added this to the 3.4.0 milestone Apr 26, 2020
@jakolehm jakolehm requested a review from a team April 26, 2020 15:17
nevalla
nevalla approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit b8fd404 into master Apr 28, 2020
@jakolehm jakolehm deleted the terminal-tag-auto-close-fixes branch April 28, 2020 05:31
@jakolehm jakolehm mentioned this pull request Apr 28, 2020
Merged
@jakolehm jakolehm mentioned this pull request May 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevalla nevalla nevalla approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jakolehm @nevalla