Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: allow to fetch kube-api objects with label & field selectors #1327

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix: allow to fetch kube-api objects with label & field selectors #1327

merged 1 commit into from
Nov 11, 2020

Conversation

ixrock
Copy link
Contributor

@ixrock ixrock commented Nov 11, 2020

Example:

  const pods = await podsApi.list({}, {
    labelSelector: [
      "k8s-app=kube-dns",
      "pod-template-hash=66bff467f8"
    ]
  });

@ixrock ixrock requested review from nevalla and jakolehm November 11, 2020 11:06
@ixrock ixrock added bug Something isn't working enhancement New feature or request labels Nov 11, 2020
@ixrock ixrock force-pushed the kube_api_label_selector branch from 41896a2 to 6a6167c Compare November 11, 2020 11:32
@ixrock ixrock force-pushed the kube_api_label_selector branch from 6a6167c to bf9a7d8 Compare November 11, 2020 11:33
jakolehm
jakolehm approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm added this to the 4.0.0 milestone Nov 11, 2020
@ixrock ixrock merged commit c67dad5 into master Nov 11, 2020
@ixrock ixrock deleted the kube_api_label_selector branch November 11, 2020 11:42
pauljwil pushed a commit to pauljwil/lens that referenced this pull request Nov 11, 2020
@ixrock
fix: allow to select kube-api objects with label & field selectors (l…
bb56366 
…ensapp#1327)

Signed-off-by: Roman <ixrock@gmail.com>
@jakolehm jakolehm mentioned this pull request Nov 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

@nevalla nevalla Awaiting requested review from nevalla

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ixrock @jakolehm