Remove windowManager from extension api #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
jakolehm
added
bug
ixrock
reviewed
Nov 11, 2020
| @@ -16,7 +16,7 @@ import { isDevelopment } from "../common/vars"; | |||
| export let tray: Tray; | |||
|
|
|||
| // refresh icon when MacOS dark/light theme has changed | |||
| nativeTheme.on("updated", () => tray?.setImage(getTrayIcon())); | |||
| nativeTheme?.on("updated", () => tray?.setImage(getTrayIcon())); | |||
There was a problem hiding this comment.
nativeTheme not available in some OS-es?
There was a problem hiding this comment.
Now that windowManager is exposed to both main/renderer this needs to be protected, nativeTheme is undefined in renderer :/
There was a problem hiding this comment.
Then probably better to move this binding to initTray(windowManager: WindowManager)
jim-docker
reviewed
Nov 11, 2020
….com:lensapp/lens into fix/remove-window-manager-from-extension-api Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
ixrock
reviewed
Nov 11, 2020
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
jim-docker
reviewed
Nov 11, 2020
|
|
||
| export class LensMainExtension extends LensExtension { | ||
| @observable.shallow appMenus: MenuRegistration[] = [] | ||
|
|
||
| async navigate(location: string, frameId?: number) { | ||
| await WindowManager.getInstance<WindowManager>().navigate(location, frameId) |
ixrock
reviewed
Nov 11, 2020
jim-docker
approved these changes
Nov 11, 2020
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
This reverts commit 03b486e. Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
pauljwil
pushed a commit
to pauljwil/lens
that referenced
this pull request
Nov 11, 2020
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1320