Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing !important statements from theme variables #1303

Merged
merged 4 commits into from
Nov 10, 2020

Conversation

aleksfront
Copy link
Contributor

Also, fixing stale theme loading error (kontena-dark gets replaced by lens-dark)

Fixes #1292

css variables

Signed-off-by: Alex Andreev alex.andreev.email@gmail.com

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront requested a review from a team November 10, 2020 09:35
@nevalla nevalla added enhancement New feature or request area/ui labels Nov 10, 2020
@nevalla nevalla added this to the 4.0.0 milestone Nov 10, 2020
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront merged commit dd90dcb into master Nov 10, 2020
@aleksfront aleksfront deleted the remove-important-from-theme-variables branch November 10, 2020 12:16
@jakolehm jakolehm mentioned this pull request Nov 10, 2020
@stefcameron
Copy link
Contributor

Thank you! 😄

pauljwil pushed a commit to pauljwil/lens that referenced this pull request Nov 11, 2020
* Removing !important statements from theme vars

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Wait for user store to load

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Fix this reference

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Aligning test with resetTheme() fixes

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global theme CSS Variable values should not be "!important"
3 participants