Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApiManager.registerStore should be simplified #1278

Merged
merged 1 commit into from
Nov 9, 2020
Merged

ApiManager.registerStore should be simplified #1278

merged 1 commit into from
Nov 9, 2020

Conversation

ixrock
Copy link
Contributor

@ixrock ixrock commented Nov 9, 2020

fix #1275

Signed-off-by: Roman ixrock@gmail.com

@ixrock
ApiManager.registerStore should be simplified #1275
2069537 
Signed-off-by: Roman <ixrock@gmail.com>
@ixrock ixrock added the enhancement New feature or request label Nov 9, 2020
@ixrock ixrock requested review from jakolehm and a team November 9, 2020 10:37
jakolehm
jakolehm approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm added this to the 4.0.0 milestone Nov 9, 2020
@ixrock ixrock merged commit 474aaae into master Nov 9, 2020
@ixrock ixrock deleted the refactor_api_manager branch November 9, 2020 11:36
@jakolehm jakolehm mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

ApiManager.registerStore should be simplified
2 participants
@ixrock @jakolehm