Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing kubeObjectDetailItems observable to LensRendererExtension #1187

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Add missing kubeObjectDetailItems observable to LensRendererExtension #1187

merged 1 commit into from
Oct 30, 2020

Conversation

jakolehm
Copy link
Contributor

This was missing in #1185

@jakolehm
add missing kubeObjectDetailItems observable to LensRendererExtension
178fbc3 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added bug Something isn't working area/extension Something to related to the extension api labels Oct 30, 2020
@jakolehm jakolehm added this to the 4.0.0 milestone Oct 30, 2020
@jakolehm jakolehm requested a review from a team October 30, 2020 14:25
jim-docker
jim-docker approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@jim-docker jim-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on a fancy extension? :)

@jakolehm
Copy link
Contributor Author

working on a fancy extension? :)

Someone is 🙂

@jakolehm jakolehm merged commit 70a8982 into master Oct 30, 2020
@jakolehm jakolehm deleted the add-missin-kube-object-detail-observable branch October 30, 2020 19:49
@jakolehm jakolehm mentioned this pull request Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-docker jim-docker jim-docker approved these changes

Assignees
No one assigned
Labels
area/extension Something to related to the extension api bug Something isn't working
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jakolehm @jim-docker