Telemetry improvements #1180
Merged
Telemetry improvements #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
nevalla
added
enhancement
nevalla
commented
Oct 30, 2020
| @@ -7,6 +7,7 @@ export default class TelemetryMainExtension extends LensMainExtension { | |||
| async onActivate() { | |||
| console.log("telemetry main extension activated") | |||
| tracker.start() | |||
| tracker.reportPeriodically() | |||
There was a problem hiding this comment.
previously reporting was done in both main and renderer processes, sending it from main processes only now.
nevalla
commented
Oct 30, 2020
| @@ -5,13 +5,12 @@ export class NodesCountDetector extends BaseClusterDetector { | |||
| key = ClusterMetadataKey.NODES_COUNT | |||
|
|
|||
| public async detect() { | |||
| if (!this.cluster.accessible) return null; | |||
There was a problem hiding this comment.
prevent overriding data with null if cluster is not accessible
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.